-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate vul chain finder to data processing platform #11
base: main
Are you sure you want to change the base?
Conversation
plugins/vulnerable-chain-finder/src/main/java/eu/f4sten/vulchainfinder/utils/DatabaseUtils.java
Show resolved
Hide resolved
plugins/vulnerable-chain-finder/src/main/java/eu/f4sten/vulchainfinder/utils/DatabaseUtils.java
Show resolved
Hide resolved
|
||
public static String createStrForSelectVulCallablesWhereModuleIdIs(final Long moduleId) { | ||
return "SELECT packages.package_name, package_versions.version, callables.fasten_uri, " + | ||
"callables.metadata -> 'vulnerabilities' " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, you can also use JOOQ's methods to get vulnerable callables given a module id instead of using a raw SQL query.
I have talked to Sebastian (@proksch) and we have decided that I can work on this feature branch, address the above comments, and deploy it on |
Yes sure, no need to even ask Amir. And sorry for not addressing the comments so far, I was waiting for the code review session that we planned to do on this PR to look at it together in person but unfortunately, it got postponed multiple times. |
…pic and prints the maven coordinate
…rable chain or not.
3e5d0f4
to
936e533
Compare
I have updated (and rebased) the branch to include the latest changes that were necessary to adopt changes from While updating, I also checked the implementation a bit... maybe we should make this plugin subject of a pair programming Monday to clarify some things about the loader platform and to talk about recurring issues that I found in several places in the code. I am also not particularly sure about the introduction of the new Error class for exception handling... I would like to discuss this with you in person before we release this plugin. |
In this PR we migrate the proof of concept implementation of VulChainFinder in the old repository to the data-processing platform.