Trigger compaction to the next level if the data age exceeds periodic_compaction_seconds #12175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
force-pushed
the
trigger-next-level-compaction-in-periodical-compact
branch
2 times, most recently
from
a85c469 to
34e7569
Compare
ajkr
previously requested changes
Dec 26, 2023
cbi42
reviewed
Dec 27, 2023
cbi42
requested changes
Dec 27, 2023
…_compaction_seconds Currently, the data are always compacted to the same level if exceeds periodic_compaction_seconds which may confuse users, so we change it to allow trigger compaction to the next level here. It's a behavior change to users, it may affect users who have disabled their ttl or ttl > periodic_compaction_seconds.
git-hulk
force-pushed
the
trigger-next-level-compaction-in-periodical-compact
branch
from
34e7569 to
3bdd044
Compare
git-hulk
force-pushed
the
trigger-next-level-compaction-in-periodical-compact
branch
from
3bdd044 to
0c48c12
Compare
git-hulk
force-pushed
the
trigger-next-level-compaction-in-periodical-compact
branch
from
3eeeca7 to
68993e7
Compare
cbi42
reviewed
Dec 27, 2023
cbi42
reviewed
Dec 27, 2023
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the data are always compacted to the same level if exceed periodic_compaction_seconds which may confuse users, so we change it to allow trigger compaction to the next level here. It's a behavior change to users, and may affect users
who have disabled their ttl or ttl > periodic_compaction_seconds.
Relate issue: #12165