Fix database open with column family. #12167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
requested changes
Dec 21, 2023
There was a problem hiding this comment.
In general this looks great thanks @rhubner, just two small changes.
rhubner
force-pushed
the
eb/column-family-fix
branch
from
da97f8e to
49ed9a0
Compare
rhubner
force-pushed
the
eb/column-family-fix
branch
from
49ed9a0 to
090761d
Compare
adamretter
approved these changes
Jan 23, 2024
When is RocksDB open with column family descriptors, the default column family must be set properly. If not, then the flush operation will fail.
rhubner
force-pushed
the
eb/column-family-fix
branch
from
090761d to
b3fe98d
Compare
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cbi42
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When is RocksDB is opened with Column Family descriptors, the default column family must be set properly. If it was not, then the flush operation will fail.