Code

Introduce NewMultiCfIterator API#12153

Code

Closed

jaykorean wants to merge 23 commits intofacebook:mainfacebook/rocksdb:mainfrom jaykorean:multi_cf_iteratorjaykorean/rocksdb:multi_cf_iteratorCopy head branch name to clipboard

+623-1

Commits

Commits on Mar 4, 2024

• MultiCfIterator Implementation - SeekToFirst() and Next() only

  jaykorean

  committed
  1a5301c

  Copy full SHA for 1a5301c

• Take key comparator from users explicitly (with default set as BytewiseComparator)

  jaykorean

  committed
  ef13ec9

  Copy full SHA for ef13ec9

• Add NewEmptyMultiColumnFamilyIterator and NewErrorMultiColumnFamilyIterator

  jaykorean

  committed
  571cc82

  Copy full SHA for 571cc82

• Remove util/heap.h dependency

  jaykorean

  committed
  e326537

  Copy full SHA for e326537

• attempt to fix linter

  jaykorean

  committed
  306712f

  Copy full SHA for 306712f

• Rebase and merge

  jaykorean

  committed
  59f14f7

  Copy full SHA for 59f14f7

• Revise comment to include wide columns handling

  jaykorean

  committed
  cc072e5

  Copy full SHA for cc072e5

• Remove unnecessary externs

  jaykorean

  committed
  0cdd17b

  Copy full SHA for 0cdd17b

• Improve Next() algorithm

  jaykorean

  committed
  452cc5c

  Copy full SHA for 452cc5c

• Add check status

  jaykorean

  committed
  6f2b8ec

  Copy full SHA for 6f2b8ec

• Use unique_ptr instead of raw pointer in the API

  jaykorean

  committed
  52af201

  Copy full SHA for 52af201

• Use the comparator from the first cf and make sure it matches comparators in all other cfs

  jaykorean

  committed
  978043d

  Copy full SHA for 978043d

• multi_cf_iterator->columns() implementation with the same invariant as value()

  jaykorean

  committed
  6b8d06d

  Copy full SHA for 6b8d06d

• fix mingw build + other minor fixes

  jaykorean

  committed
  868239b

  Copy full SHA for 868239b

• linter fix

  jaykorean

  committed
  341af76

  Copy full SHA for 341af76

• Rebase and remove unnecessary include

  jaykorean

  committed
  c074aaf

  Copy full SHA for c074aaf

• Fix linter and rebase

  jaykorean

  committed
  5a852d9

  Copy full SHA for 5a852d9

• Address feedback

  jaykorean

  committed
  f160b4e

  Copy full SHA for f160b4e

• Make MultiCFIter not valid for only one CF

  jaykorean

  committed
  de2f338

  Copy full SHA for de2f338

• Use the generic iterator interface instead of multi_cf_iterator for unified experience

  jaykorean

  committed
  d221bf3

  Copy full SHA for d221bf3

• rename MultiCfIteratorImpl to MultiCfIterator

  jaykorean

  committed
  8a22393

  Copy full SHA for 8a22393

• remove unused include

  jaykorean

  committed
  c8b5805

  Copy full SHA for c8b5805

• remove attribute_groups() api for now

  jaykorean

  committed
  3a42a58

  Copy full SHA for 3a42a58