Change Java native methods to static #11882
Conversation
rhubner
changed the title
There was a problem hiding this comment.
LGTM. Appears on reading through to do what is intended, and I am not aware of any omissions. Are we sure that UTs are comprehensive, i.e. all native methods are covered by the UTs ? Could we look at having a ticket based on #11221 which ensures that ? (not something we can do now, just an idea for reference)
alanpaxton
force-pushed
the
jni-static
branch
2 times, most recently
from
c78147f to
1c00673
Compare
rhubner
force-pushed
the
jni-static
branch
2 times, most recently
from
915c1c1 to
f1f69f3
Compare
|
@rhubner Can we get this rebased please? |
There was a problem hiding this comment.
LGTM. @rhubner can you rebase please? @ajkr @pdillinger the changes in this PR are mostly mechanical and follow the same single pattern over-and-over again, as soon as it is rebased and CI passes can we get this one merged please?
This should give us some performance benefit calling native C++ code. See bug facebook#4786 and https://github.com/evolvedbinary/jni-benchmarks/ for more info.
|
@ajkr @pdillinger can we get this imported ASAP please? |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This should give us some performance benefit calling native C++ code.
Closes #4786
See https://github.com/evolvedbinary/jni-benchmarks/ for more info.