Skip to content

Commit

Permalink
Don't fail crash test if cleanup cmd fails after successful test (#13287
Browse files Browse the repository at this point in the history
)

Summary:
The warm storage crash test sometimes fails due to the cleanup command failing if the db_stress exited successfully and we already cleaned up. This results in false alarms. Don't treat a cleanup command failure as crash test failure.

Pull Request resolved: #13287

Reviewed By: archang19

Differential Revision: D68023398

Pulled By: anand1976

fbshipit-source-id: f95fff030a5ea8eb7d2dfb248d08d7876e2de2b2
  • Loading branch information
anand1976 authored and facebook-github-bot committed Jan 10, 2025
1 parent 6c6defe commit 3040868
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1156,8 +1156,7 @@ def cleanup_after_success(dbname):
print("Running DB cleanup command - %s\n" % cleanup_cmd)
ret = os.system(cleanup_cmd)
if ret != 0:
print("TEST FAILED. DB cleanup returned error %d\n" % ret)
sys.exit(1)
print("WARNING: DB cleanup returned error %d\n" % ret)


# This script runs and kills db_stress multiple times. It checks consistency
Expand Down

0 comments on commit 3040868

Please sign in to comment.