Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix ldb_cmd_test.cc build with nondefault -DROCKSDB_NAMESPACE (#12173)
Summary: I landed #12159 which had the below compiler error when using `-DROCKSDB_NAMESPACE`, which broke the CircleCI "build-linux-static_lib-alt_namespace-status_checked" job: ``` tools/ldb_cmd_test.cc:1213:21: error: 'rocksdb' does not name a type 1213 | int Compare(const rocksdb::Slice& a, const rocksdb::Slice& b) const override { | ^~~~~~~ tools/ldb_cmd_test.cc:1213:35: error: expected unqualified-id before '&' token 1213 | int Compare(const rocksdb::Slice& a, const rocksdb::Slice& b) const override { | ^ tools/ldb_cmd_test.cc:1213:35: error: expected ')' before '&' token 1213 | int Compare(const rocksdb::Slice& a, const rocksdb::Slice& b) const override { | ~ ^ | ) tools/ldb_cmd_test.cc:1213:35: error: expected ';' at end of member declaration 1213 | int Compare(const rocksdb::Slice& a, const rocksdb::Slice& b) const override { | ^ | ; tools/ldb_cmd_test.cc:1213:37: error: 'a' does not name a type 1213 | int Compare(const rocksdb::Slice& a, const rocksdb::Slice& b) const override { | ^ ... ``` Pull Request resolved: #12173 Test Plan: ``` $ make clean && make OPT="-DROCKSDB_NAMESPACE=alternative_rocksdb_ns" ldb_cmd_test -j56 ``` Reviewed By: pdillinger Differential Revision: D52373797 Pulled By: ajkr fbshipit-source-id: 8597aaae65a5333831fef66d85072827c5fb1187
- Loading branch information