Skip to content

Commit

Permalink
Make ServiceInfoHolder dependency non-transitive
Browse files Browse the repository at this point in the history
Summary: After refactoring `ServiceInfoHolder`, `AsyncProcessor` no longer has a dependency on `ServiceInfoHolder`. Various test fixtures depend on the symbol transitively by including `AsyncProcessor`. This diff moves the dependency out for clarity.

Reviewed By: sazonovkirill

Differential Revision: D67882822

fbshipit-source-id: 42ebeb428cd49b3727e955d86f8826306904b577
  • Loading branch information
Evan Zou authored and facebook-github-bot committed Jan 10, 2025
1 parent c9f4819 commit 838a170
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions thrift/lib/cpp2/GeneratedCodeHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <thrift/lib/cpp2/async/ClientBufferedStream.h>
#include <thrift/lib/cpp2/async/ClientSinkBridge.h>
#include <thrift/lib/cpp2/async/RequestChannel.h>
#include <thrift/lib/cpp2/async/ServiceInfoHolder.h>
#include <thrift/lib/cpp2/async/Sink.h>
#include <thrift/lib/cpp2/async/StreamCallbacks.h>
#include <thrift/lib/cpp2/detail/meta.h>
Expand Down
1 change: 0 additions & 1 deletion thrift/lib/cpp2/async/AsyncProcessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
#include <thrift/lib/cpp2/async/SchemaV1.h>
#include <thrift/lib/cpp2/async/ServerRequestData.h>
#include <thrift/lib/cpp2/async/ServerStream.h>
#include <thrift/lib/cpp2/async/ServiceInfoHolder.h>
#include <thrift/lib/cpp2/async/Sink.h>
#include <thrift/lib/cpp2/protocol/Protocol.h>
#include <thrift/lib/cpp2/server/ConcurrencyControllerInterface.h>
Expand Down
1 change: 1 addition & 0 deletions thrift/lib/cpp2/gen/service_h.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <thrift/lib/cpp2/async/FutureRequest.h>
#include <thrift/lib/cpp2/async/HeaderChannel.h>
#include <thrift/lib/cpp2/async/RequestChannel.h>
#include <thrift/lib/cpp2/async/ServiceInfoHolder.h>

namespace folly {

Expand Down

0 comments on commit 838a170

Please sign in to comment.