Skip to content

Commit

Permalink
Revert D67959504: Log dummy operations
Browse files Browse the repository at this point in the history
Differential Revision:
D67959504

Original commit changeset: 4e2439954b68

Original Phabricator Diff: D67959504

fbshipit-source-id: dfd989c37d2bb2b0241876c34721c63bc577b203
  • Loading branch information
Mizuchi authored and facebook-github-bot committed Jan 14, 2025
1 parent d63316a commit 171bd6f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions thrift/lib/cpp2/op/detail/ContainerPatch.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ class ListPatch : public BaseContainerPatch<Patch, ListPatch<Patch>> {
return;
}

patch::detail::logDeprecatedOperation(
"ListPatch::Dummy", folly::pretty_name<T>(), "");
if (!data_.prepend()->empty()) {
auto msg = "Prepend in ListPatch is disallowed.";
LOG(DFATAL) << msg;
Expand Down
2 changes: 0 additions & 2 deletions thrift/lib/cpp2/protocol/Patch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ void ApplyPatch::operator()(
insert_set(*validate_if_set(add, "add"));
}

patch::detail::logDeprecatedOperation("SetPatch::Dummy", "[dynamic]", "");
if (auto* put = findOp(patch, PatchOp::Put)) {
auto msg = "SetPatch::Put should be migrated to SetPatch::Add";
patch::detail::logDeprecatedOperation("SetPatch::Put", "[dynamic]", msg);
Expand Down Expand Up @@ -412,7 +411,6 @@ void ApplyPatch::operator()(

template <class Patch>
void impl(Patch&& patch, Object& value) {
patch::detail::logDeprecatedOperation("StructPatch::Dummy", "[dynamic]", "");
static_assert(std::is_same_v<folly::remove_cvref_t<Patch>, Object>);
checkOps(
patch,
Expand Down

0 comments on commit 171bd6f

Please sign in to comment.