Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable https and http liveliness and readyness probes #15

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Skarlso
Copy link
Collaborator

@Skarlso Skarlso commented Aug 13, 2024

Problem Statement

Probes were previously disabled in HTTPS environment. It should work now.

Related Issue

Fixes #14

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso Skarlso force-pushed the add-liveness-readiness branch from a218b0c to 78f0738 Compare August 13, 2024 05:42
@Skarlso Skarlso force-pushed the add-liveness-readiness branch from 78f0738 to 71efc43 Compare August 13, 2024 05:43
@Skarlso
Copy link
Collaborator Author

Skarlso commented Aug 13, 2024

Both probes are functioning correctly after testing.

@Skarlso
Copy link
Collaborator Author

Skarlso commented Aug 13, 2024

Actually gonna add some helm tests.

@Skarlso Skarlso force-pushed the add-liveness-readiness branch from eecf827 to 5d81ef8 Compare August 13, 2024 07:44
Signed-off-by: Gergely Brautigam <[email protected]>
@Skarlso Skarlso force-pushed the add-liveness-readiness branch from 5d81ef8 to fe947d4 Compare August 13, 2024 07:46
@Skarlso Skarlso merged commit 3a0f180 into main Aug 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liveness and readiness probes are left out
1 participant