[BUGFIX] Remove falsy path in phplint config #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the path to `path: ./../` gets wrong results as it make the linter running in the parent directory. Simply removing works when running it with the composer command. phplint is not used by the CI
|
I would suggest to remove the phplint command, because it is only used in the composer script section and replace the linting in the script with |
|
I removed phplint in f141db0 and use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the path to
path: ./../gets wrongresults as it make the linter running in the
parent directory of the extensoin.
Simply removing works when
running it with the composer command.
Note: phplint is not used by the CI!