[BUGFIX] Proper storage of taxes for an order #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an order the EventListener created tax records. These records are never used and not even configured in the TCA so they are not even related to the orderProduct after there creation (field `item` is `0` after persisting them in the table.)
This adds an EventListener which persists the fields `tax` and `totalTax` for an orderItem so that those values can be used for PDFs and of course also to show them in the BE view. Fixes: #509
An order has two different taxes: * `tax`: That's the tax for all the products in the cart. * `totalTax`: That's the tax for the whole order which includes the tax from above plus tax on services like shipping and/or payment. Before this bugfix the taxes were not persisted properly because the relation was not correct implemented in TCA. By introducing the `foreign_match_fields` the relations are correctly resolved. Fixes: #312
This setting is removed since TYPO3 v7, see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/7.4/Breaking-67753-DropSecondaryOptions.html#tca
extcode
changed the title
Relates: #521
extcode
force-pushed
the
bugfix/312/multiple-tax-entries-v2
branch
from
d142b97 to
30b8b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render fields tax and orderTax in BE List module.
Fixes: #312, #509