Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update with rector #496

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

rintisch
Copy link
Collaborator

  • Update rector to v2.6
  • Update rector configuration to latest scheme.
  • Add rector php set for php 8.1
  • Prepare some files to avoid deletion of relevant code and to avoid annotations (instead of attributes) in __construct() parameter lists.

Todo:
Actually run rector with .build/bin/rector process

@rintisch rintisch force-pushed the task/update-rector branch from d7d62b2 to 9036085 Compare May 25, 2024 12:09
@rintisch rintisch requested a review from extcode May 25, 2024 12:10
! Did commit does not include a rector run!

This contains all preparations for a rector run:
* Update rector to v2.6
* Update rector configuration to latest scheme.
* Add rector php set for php 8.1
* Prepare some files to avoid deletion of
  relevant code and to avoid annotations (instead
  of attributes) in `__construct()` parameter
  lists.
@rintisch rintisch force-pushed the task/update-rector branch from 9036085 to a34d038 Compare May 25, 2024 12:23
@rintisch
Copy link
Collaborator Author

@extcode
I did only prepare the update. I thought you might want to make the final step yourself to see why changes are done. This information is only visible during the update process and gets lost in the commit.

@extcode extcode merged commit 89eeb91 into extcode:main May 30, 2024
9 checks passed
@rintisch rintisch deleted the task/update-rector branch June 11, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants