[FEATURE] JS changes available BE variant stock #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With activated stock handling for BE variants the JavaScript which changes the prices does also change change the available stock. Requirements: -This requires that the select view contains a data atrribute 'data-available-stock' with the stock for the BE variant. - Furthermore some HTML has to be present which will be used to insert the available stock. Both changes will be made in a commit in EXT:cart_products. !!! This commit changes also the buggy behaviour that reselecting "Please choose..." from the select field shows the price of the last chosen item. Instead a ` ` will be inserted (to display no price while avoiding 'jumping' layout. Fixes: extcode#487
rintisch
force-pushed
the
task/show-stock-of-be-variants
branch
from
21cda83 to
76fa5e0
Compare
extcode
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With activated stock handling for BE variants
the JavaScript which changes the prices does
also change change the available stock.
Requirements:
a data atrribute 'data-available-stock' with
the stock for the BE variant.
Both changes will be made in a commit in
EXT:cart_products.
!!!
This commit changes also the buggy behaviour that
reselecting "Please choose..." from the select
field shows the price of the last chosen item.
Instead a
will be inserted (to displayno price while avoiding 'jumping' layout.
Fixes: #487