Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix dashboard widgets for v12 #476

Merged
merged 4 commits into from
May 24, 2024

Conversation

rintisch
Copy link
Collaborator

@rintisch rintisch commented Apr 9, 2024

  • BarChartWidgets need a BackendViewFactory
    which is added now.
  • Fix PaymentPaidShippingOpen widget

Fixes #475

@rintisch rintisch marked this pull request as draft April 12, 2024 18:28
@rintisch rintisch force-pushed the bug/issue-475-fix-dashboard-widgets branch 2 times, most recently from e7ea8b8 to 27e675b Compare April 14, 2024 12:37
@rintisch rintisch changed the title WIP [BUG] Fix BarChartWidgets in v12 [BUG] Fix BarChartWidgets in v12 Apr 14, 2024
@rintisch rintisch marked this pull request as ready for review April 14, 2024 12:50
@rintisch rintisch requested a review from extcode April 14, 2024 12:50
@rintisch rintisch changed the title [BUG] Fix BarChartWidgets in v12 [BUG] Fix dashboard widgets for v12 Apr 14, 2024
@rintisch
Copy link
Collaborator Author

@extcode The violation that is marked in the coding guideline is fixed in #477. Best to merge that first, afterwards I will rebase this commit.

@rintisch rintisch changed the title [BUG] Fix dashboard widgets for v12 [BUGFIX] Fix dashboard widgets for v12 May 22, 2024
Configuration/TypoScript/setup.typoscript Outdated Show resolved Hide resolved
Configuration/page.tsconfig Outdated Show resolved Hide resolved
rintisch added 4 commits May 24, 2024 18:17
BarChartWidgets need a BackendViewFactory
which is added now.
* Rename template due to recommended namespacing.
* Remove deprecated StandaloneView
* Add `page.tsconfig` for template path definition.
Add empty lines at the end of files.
@rintisch rintisch force-pushed the bug/issue-475-fix-dashboard-widgets branch from e3cede5 to 71ae36d Compare May 24, 2024 16:18
@extcode extcode merged commit 32731ed into extcode:main May 24, 2024
9 checks passed
@rintisch rintisch deleted the bug/issue-475-fix-dashboard-widgets branch June 11, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Widgets broken in v12
2 participants