Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Switch hooks to PSR-14 events #469

Merged
merged 13 commits into from
May 24, 2024

Conversation

extcode
Copy link
Owner

@extcode extcode commented Apr 1, 2024

No description provided.

@extcode extcode self-assigned this Apr 1, 2024
@extcode extcode changed the title Task/452/switch hooks to psr14 events [TASK] Switch hooks to PSR-14 events Apr 1, 2024
Copy link
Collaborator

@rintisch rintisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without further testing did I add some comments

Classes/Controller/Cart/CartController.php Outdated Show resolved Hide resolved
Classes/Domain/Finisher/Form/AddToCartFinisher.php Outdated Show resolved Hide resolved
Documentation/Developer/Events/Index.rst Outdated Show resolved Hide resolved
Documentation/Developer/Events/Index.rst Outdated Show resolved Hide resolved
Documentation/Changelog/9.0/Breaking-452-RemoveHooks.rst Outdated Show resolved Hide resolved
Classes/Service/SessionHandler.php Outdated Show resolved Hide resolved
Classes/EventListener/Mail/AttachmentFromOrderItem.php Outdated Show resolved Hide resolved
Configuration/Services.yaml Outdated Show resolved Hide resolved
@extcode extcode force-pushed the task/452/switch_hooks_to_psr14_events branch 3 times, most recently from 8e8ebdb to df8ec6f Compare April 15, 2024 19:23
@rintisch rintisch force-pushed the task/452/switch_hooks_to_psr14_events branch 2 times, most recently from d8813e8 to df8ec6f Compare May 22, 2024 07:29
@extcode extcode force-pushed the task/452/switch_hooks_to_psr14_events branch from f705068 to 4bf210d Compare May 24, 2024 20:07
@extcode extcode merged commit 39c6455 into main May 24, 2024
9 checks passed
@extcode extcode deleted the task/452/switch_hooks_to_psr14_events branch June 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants