[TASK] Replace hooks with PSR-14 events #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintisch
force-pushed
the
task/issue-452-replace-hooks
branch
from
33ce150 to
6e40801
Compare
|
@extcode |
rintisch
force-pushed
the
task/issue-452-replace-hooks
branch
from
6e40801 to
70e4625
Compare
Replace existing hooks with PSR-14 events
rintisch
force-pushed
the
task/issue-452-replace-hooks
branch
from
70e4625 to
19daf12
Compare
|
I had started a branch some days ago and replacing the same hook. I think we do not need an Interface for this event. I added an interface for events, because I cycling over a list of events for different tasks. |
|
Okay, it was at least a nice learning for me. Maybe the documentation adaption might be useful for you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace existing hooks with PSR-14 events
Todo:
Fixes #452