[TASK] Cleanup TypoScript orderNumber generation #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With extcode@5c13a1e#diff-b283fa76060bccbae79c0465294ef56f7ebf57b8e70dab356a1d7c48d7f00ee9 the definition of the orderNumberGenerator moved to `Services.yaml`. It was missed to remove the definition in the `constants.typoscript` which is now done.
extcode
approved these changes
Mar 23, 2024
rintisch
deleted the
task/issue-339-cleanup-number-generation-in-typoscript
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 5c13a1e#diff-b283fa76060bccbae79c0465294ef56f7ebf57b8e70dab356a1d7c48d7f00ee9 the definition of the orderNumberGenerator moved
to
Services.yaml.It was missed to remove the definition in the
constants.typoscriptwhich is now done.This issue was triggered by feedback in #399