[BUGFIX] Taxclass 'calc' can have value (int)0

Setting a the value `calc` of a taxClass to the integer value '0' works and does no longer result in an error. Fixes #430
extcode · Mar 25, 2024 · 338c7f3 · 338c7f3
1 parent f09d45f
commit 338c7f3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/Classes/Service/TaxClassService.php b/Classes/Service/TaxClassService.php
@@ -71,11 +71,10 @@ protected function isValidTaxClassConfig(int $key, array $value): bool
     {
         if (empty($value) ||
             empty($value['name']) ||
-            empty($value['calc']) ||
-            !is_numeric($value['calc'])
+            (isset($value['calc']) && !is_numeric($value['calc']))
         ) {
             $logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(__CLASS__);
-            $logger->error('Can\'t create tax class object for \'' . $key . '\'.', []);
+            $logger->error('Can\'t create tax class object for the configuration with the index=' . $key . '.', []);
 
             return false;
         }

diff --git a/Tests/Functional/Service/TaxClassServiceTest.php b/Tests/Functional/Service/TaxClassServiceTest.php
@@ -256,4 +256,32 @@ public function parsingTaxClassesFromTypoScriptWithNotConfiguredCountryCodeRetur
             $firstTaxClasses->getTitle()
         );
     }
+
+    /**
+     * @test
+     */
+    public function parsingTaxClassesFromTypoScriptWithIntegerZeroAsCalcIsValid()
+    {
+        $settings = [
+            'taxClasses' => [
+                '1' => [
+                    'value' => '0',
+                    'calc' => '0',
+                    'name' => 'free',
+                ],
+            ],
+        ];
+
+        $reflection = new \ReflectionClass($this->taxClassService);
+        $reflection_property = $reflection->getProperty('settings');
+        $reflection_property->setAccessible(true);
+        $reflection_property->setValue($this->taxClassService, $settings);
+
+        $taxClasses = $this->taxClassService->getTaxClasses();
+
+        self::assertEquals(
+            $taxClasses[1]->getCalc(),
+            0
+        );
+    }
 }