txmgr: Add custom publish error message handling #13856
Open
+114
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13856 +/- ##
============================================
+ Coverage 46.99% 79.21% +32.21%
============================================
Files 967 167 -800
Lines 80759 9440 -71319
Branches 774 774
============================================
- Hits 37956 7478 -30478
+ Misses 39911 1700 -38211
+ Partials 2892 262 -2630
Flags with carried forward coverage won't be shown. Click here to find out more. |
protolambda
approved these changes
Jan 20, 2025
| &cli.StringSliceFlag{ | ||
| Name: AlreadyPublishedCustomErrsFlagName, | ||
| Usage: "List of custom RPC error messages that indicate that a transaction has already been published.", | ||
| EnvVars: prefixEnvVars("ALREADY_PUBLISHED_CUSTOM_ERRS"), |
There was a problem hiding this comment.
Suggested change
| EnvVars: prefixEnvVars("ALREADY_PUBLISHED_CUSTOM_ERRS"), | |
| EnvVars: prefixEnvVars("TXMGR_ALREADY_PUBLISHED_CUSTOM_ERRS"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to configure a "List of custom RPC error messages that indicate that a transaction has already been published."
Some (proprietary) RPC providers respond with custom errors when a transaction got already published or even mined, see #13739. This would let the txmgr enter a publishing loop repeatedly hitting the same error that should be interpreted as a signal that a transaction actually already got published.
Tests
Added a test that a custom rpc error returned from a transaction publication is interpreted as a successful send.
Metadata
Fixes #13739