Update CLI release policy #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the EC policy config for the CLI image in two ways. First, the policy config now enforces hermetic builds since the builds are indeed hermetic 🎉. Second the policy config no longer enforces the schedule restriction. Those policy rules are usually meant to avoid releases by a vendor on restricted dates, e.g. weekends. Since this is being used for a community release, this is not a concern. Ref: EC-911 Signed-off-by: Luiz Carvalho <[email protected]>
simonbaird
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
=======================================
Coverage 72.76% 72.76%
=======================================
Files 89 89
Lines 7674 7674
=======================================
Hits 5584 5584
Misses 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the EC policy config for the CLI image in two ways.
First, the policy config now enforces hermetic builds since the builds are indeed hermetic 🎉.
Second the policy config no longer enforces the schedule restriction. Those policy rules are usually meant to avoid releases by a vendor on restricted dates, e.g. weekends. Since this is being used for a community release, this is not a concern.
Ref: EC-911