Fixed incorrect parsing of ipv6 addresses in RSGI and WSGI access logs (

#477)
emmett-framework · Jan 8, 2025 · ceab635 · ceab635
1 parent a995402
commit ceab635
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/granian/rsgi.py b/granian/rsgi.py
@@ -107,7 +107,7 @@ def access_log(t, scope, resp_code):
         logger(
             t,
             {
-                'addr_remote': scope.client.split(':')[0],
+                'addr_remote': scope.client.rsplit(':', 1)[0],
                 'protocol': 'HTTP/' + scope.http_version,
                 'path': scope.path,
                 'qs': scope.query_string,

diff --git a/granian/wsgi.py b/granian/wsgi.py
@@ -80,7 +80,7 @@ def access_log(t, scope, resp_code):
         logger(
             t,
             {
-                'addr_remote': scope['REMOTE_ADDR'].split(':')[0],
+                'addr_remote': scope['REMOTE_ADDR'].rsplit(':', 1)[0],
                 'protocol': scope['SERVER_PROTOCOL'],
                 'path': scope['PATH_INFO'],
                 'qs': scope['QUERY_STRING'],