Tests named 30 days are run over 30 days #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request attending to a possible regression in the behavior of the Approval tests in DotNet
introduced after
e188fae#diff-5e77a617e97d9e66a013c079bfbdb3eb0987e563b1a92aa74c2d0349bc88bb59
The Main program, used by the approval tests has a default number of Days set to 2 to support the texttests command line approval test - which is being updated to be a ubiquitous approval test adapter for any language
The tests in the DotNet targeted solutions are named ThirtyDays.
Since they do not provide an override for the number of days, they are currently only running the business logic for 2 days.
(I believe that this means that the approval tests do not demonstrate the rule that the back stage pass quality is set to zero after sell in expires - the first instance of this condition seems to occur on day 6)
Given the tests were historically named ThrityDays, and were run over ThirtyDays, I would describe this as a regression.
This pull request adds the required parameter to the program to restore ThirtyDays for dotnet
Other languages that may also be affected this are Java and FSharp, but they are not included in this pull request