New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include static partial names in the list of renderables. #28

Open

rwjblue wants to merge 1 commit into master from deal-with-partials

Member

rwjblue commented Apr 24, 2016

Addresses #27.

There are still some open questions about where exactly a localized partial would go in the new proposal.

Given the following route template (and assuming it was the only usage of the partial):

{{! app/templates/posts/show.hbs }}

<div>
  {{partial "post-display"}}
</div>

Currently, the migrator will make the following layout:

src/ui/routes/posts/show/template.hbs
src/ui/routes/post-display.hbs

This seems non-ideal, but I am unsure what should actually happen here...


          Include static partial names in the list of renderables.

d23fc0c

Contributor

iezer commented Mar 31, 2017

According to the spec, the file should go into src/ui/partials/post-display.hbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet