Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement highlight a duration when preview line changed #16

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

LiuYinCarl
Copy link
Contributor

goto-line-preview.mp4

@LiuYinCarl
Copy link
Contributor Author

The CI error seems a little confusing and seems to have nothing to do with this code change.

@LiuYinCarl
Copy link
Contributor Author

Implement the suggestion. #14 (comment)

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! And yeah, don't worry about the CI since there are bugs in the windows snapshot! ;)

goto-line-preview.el Show resolved Hide resolved
@jcs090218 jcs090218 added the enhancement New feature or request label Feb 5, 2024
@jcs090218 jcs090218 merged commit 5cc4755 into emacs-vs:master Feb 6, 2024
14 of 15 checks passed
@jcs090218
Copy link
Member

LGTM! Thank you!

@jcs090218
Copy link
Member

Sorry, I've change the color variable goto-line-preview-hl-color to a face goto-line-preview-hl since it's the standard way to define a custom color. See c98dc62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants