Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make proWES run locally #94

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix: make proWES run locally #94

wants to merge 6 commits into from

Conversation

JaeAeich
Copy link
Contributor

@JaeAeich JaeAeich commented Dec 19, 2024

fixes - #93

Summary by Sourcery

Enable proWES to run locally by introducing environment-based configuration file selection, adding a Makefile for development tasks, and updating Docker Compose settings.

Bug Fixes:

  • Fix the local execution of proWES by adjusting the configuration file path based on the environment.

Enhancements:

  • Add a Makefile to streamline development tasks such as creating a virtual environment and running services locally.

Build:

  • Update the Docker Compose command to correctly navigate to the application directory before starting the Gunicorn server.

Documentation:

  • Add a development configuration file 'config.dev.yaml' to facilitate local development with specific settings.

Copy link

sourcery-ai bot commented Dec 19, 2024

Reviewer's Guide by Sourcery

This PR implements changes to make proWES run locally in a development environment. The main changes include adding a development configuration file, updating path configurations, introducing environment-based config selection, and adding development tooling through a Makefile and a development-specific docker-compose file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added environment-based configuration file selection
  • Added logic to select config.dev.yaml when ENVIRONMENT is set to DEV
  • Added default ENVIRONMENT=DEV setting for local development
  • Created new config.dev.yaml with development-specific settings
pro_wes/app.py
pro_wes/config.dev.yaml
Updated API and service paths for local development
  • Modified API specification paths to include pro_wes prefix
  • Updated docker command path to reference correct wsgi application
  • Added specific pymongo version requirement
pro_wes/config.yaml
docker-compose.yaml
requirements.txt
Added development tooling and infrastructure
  • Created Makefile with development commands and targets
  • Added development-specific docker-compose configuration
  • Included commands for running app, Celery worker, and Docker services locally
Makefile
docker-compose.dev.yaml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JaeAeich JaeAeich requested a review from uniqueg December 19, 2024 10:44
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's neat, but I will not approve this, given that we are planning to address this centrally through FOCA. Just use it locally on your system. After all, you're the only one currently working on this, and nobody else minded - so I don't see the need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants