-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make proWES run locally #94
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR implements changes to make proWES run locally in a development environment. The main changes include adding a development configuration file, updating path configurations, introducing environment-based config selection, and adding development tooling through a Makefile and a development-specific docker-compose file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's neat, but I will not approve this, given that we are planning to address this centrally through FOCA. Just use it locally on your system. After all, you're the only one currently working on this, and nobody else minded - so I don't see the need.
fixes - #93
Summary by Sourcery
Enable proWES to run locally by introducing environment-based configuration file selection, adding a Makefile for development tasks, and updating Docker Compose settings.
Bug Fixes:
Enhancements:
Build:
Documentation: