test: add integration tests #40
Conversation
tests/integration_tests.py
Outdated
| base_url = "http://localhost:8080/ga4gh/drs/v1" | ||
| data_objects_path = "data_objects.json" | ||
| headers = { | ||
| 'accept': 'application/json', |
There was a problem hiding this comment.
I think it should be Accept with a capital A: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept
tests/integration_tests.py
Outdated
| 'accept': 'application/json', | ||
| 'Content-Type': 'application/json' | ||
| } | ||
| payload_objects = json.dumps({ |
There was a problem hiding this comment.
Can some object from "data_objects.json" perhaps be reused here instead of hardcoding another 50 lines of payload in here?
tests/integration_tests.py
Outdated
| "alias1" | ||
| ] | ||
| }) | ||
| payload_service_info = json.dumps({ |
There was a problem hiding this comment.
Can the payload JSON perhaps be externalized so that it can be easily reused and keep this module cleaner? See here, e.g.: https://github.com/elixir-cloud-aai/trs-filer/blob/dev/tests/mock_data.py
| endpoint = "/objects/" + object_id | ||
| response = requests.request("DELETE", base_url + endpoint, headers=headers) | ||
| assert response.status_code == 200 | ||
| assert response.text.replace("\"", "").replace("\n", "") == object_id |
There was a problem hiding this comment.
Would be good to add test cases for some errors as well, especially 404 and 400. Eventually we should cover 401 and 403 as well, but we can do that once we have a better idea of how controlled access management will look like
.travis.yml
Outdated
| @@ -7,7 +7,10 @@ language: python | |||
| # this ensures that the pipeline is triggered for internal pushes, | |||
| # PRs from forks and pushes to existing PRs from forks | |||
| if: (type == push) OR (type == pull_request AND fork == true) | |||
|
|
|||
| branches: | |||
There was a problem hiding this comment.
Oh, this is why it didn't trigger a Travis run. Why did you add that? I think we would like to run tests always, for each PR. If you would like for specific tests (like integration tests), you should make use of different stages or a job matrix, then introduce conditions for branches separately for each stage/job. It should also be possible to use conditions on the exact commands, but the syntax is not great and it can quickly become unreadable for more complicated files. In any case, I don't see a good reason why we should not run the Travis CI for all PRs as well, the tests should be fast enough...
There was a problem hiding this comment.
(so I would just remove this block again unless there is a convincing reason to keep it)
Added integration tests for responses and & created mock_data.py to avoid hard coding payload at integration_tests.py
Minor fix: mock_data
|
Made required changes. But still not sure about tests for response I think there is a need to add tests for response |
Description
Added Integration tests that test the functionality of each endpoint.
Fixes #39