Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mongodb host config #52

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Allow mongodb host config #52

merged 2 commits into from
Jul 16, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jul 16, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request introduces the ability to configure the MongoDB host through an environment variable (MONGO_HOST). It updates the configuration script and deployment template to support this new configuration option.

  • New Features:
    • Added support for configuring MongoDB host via environment variable MONGO_HOST.
  • Enhancements:
    • Updated the update-config-map.sh script to include MONGO_HOST in the configuration process.
    • Modified the cloud-registry-configmap-job.yaml template to set the MONGO_HOST environment variable.

Copy link

sourcery-ai bot commented Jul 16, 2024

Reviewer's Guide by Sourcery

This pull request introduces the ability to configure the MongoDB host through an environment variable. The changes include adding a check and default value for the MONGO_HOST variable in the update-config-map.sh script, updating the yq command to use this variable, and modifying the Kubernetes job template to include the MONGO_HOST environment variable.

File-Level Changes

Files Changes
update-config-map.sh
deployment/templates/cloud-registry-configmap-job.yaml
Introduced configuration for MongoDB host by adding MONGO_HOST environment variable handling in both the shell script and Kubernetes job template.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@lvarin lvarin force-pushed the allow-mongodb-host-config branch from 62cac5e to 25e9aef Compare July 16, 2024 05:23
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0a4c7ff) to head (8906b5e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          189       189           
=========================================
  Hits           189       189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvarin lvarin force-pushed the allow-mongodb-host-config branch from 25e9aef to d519f1c Compare July 16, 2024 05:36
@lvarin lvarin requested a review from jemaltahir July 16, 2024 05:54
Copy link

@jemaltahir jemaltahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemaltahir jemaltahir merged commit fa8a1b0 into dev Jul 16, 2024
6 checks passed
@jemaltahir jemaltahir deleted the allow-mongodb-host-config branch July 16, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants