fix: Make submit button enabled when required fields are filled by default

[SalihuDickson]

Description

Fixes #385

Checklist

This fixes the issue where the submit button is disabled when required fields are filled by default

• My code follows the contributing guidelines of this project.
• I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
• I have performed a self-review of my own code.
• I have commented my code in hard-to-understand areas.
• I have updated the user-facing documentation to describe any new or changed behavior.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• I have not reduced the existing code coverage.

Comments

Summary by Sourcery

Bug Fixes:

• Ensure the submit button is enabled when required fields are filled by default by adjusting the logic that manages the 'requiredButEmpty' list.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2edff7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@elixir-cloud/design	Patch
@elixir-cloud/tes	Patch
@elixir-cloud/wes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a bug where the submit button remains disabled even when required form fields have default values. The implementation modifies the form validation logic to properly handle default values and maintain the required fields state.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Improved required fields validation logic	Added check for default values when form hasn't been updated yet Prevented adding fields with default values to requiredButEmpty array on initial render Added logic to remove fields from requiredButEmpty when they get filled Removed redundant requiredButEmpty reset in render method	packages/ecc-utils-design/src/components/form/form.ts

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#385	Fix submit button not disabling when required fields are cleared	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
elixir-cloud-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 4:51pm

[sourcery-ai]

Hey @SalihuDickson - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider refactoring the empty if block with eslint-disable. The logic could be more clearly expressed by combining the conditions rather than using an empty block.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[SalihuDickson]

hey @anuragxxd, please take a look at this.