-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added readonly type field #384
Added readonly type field #384
Conversation
|
Reviewer's Guide by SourceryThe PR adds a new readonly @type field to the dataset entity configuration in the RO-Crate client. The implementation adds a new array field configuration with a single text input that is set as readonly and defaults to "Dataset". No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sivangbagri - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete a self-review of the code and update the checklist accordingly.
- Consider updating the user documentation to reflect this new readonly type field, even if the change is minimal.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Added readonly @type field in dataset entity.
Fixes #(issue)
Checklist
Comments
Summary by Sourcery
New Features: