Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove template strings & fix link #17

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented Jul 13, 2022

Description

Please include a summary of the change and the relevant issue(s) it resolves,
if any (otherwise delete that line). Please also include relevant motivation
and context briefly, especially if there exists no related issue and the
change is non-trivial. List any dependencies that are required for this
change. Please use bullet points for the description. For very trivial issues
that are duly explained by the PR title, a description can be omitted.

Checklist

Please go through the following checklist to ensure that your change is ready
for review. Please do not forget to double check the list after you have
modified your PR, e.g., if you have added commits to address reviewer
comments or to fix failing automated checks. Please check items also if they
do not apply to your change, e.g., if your change does not require an update
of the user-facing documentation, then still check the box. Generally, PRs
are only reviewed when all boxes are ticked off and all automated checks pass
(use the comment section below if you believe that your PR is ready to be
merged even though not all boxes were ticked off).

  • My code follows the contributing guidelines of this
    project, including, in particular, with regard to any style guidelines
  • The title of my PR complies with the Conventional Commits
    specification
    ; in particular, it clearly indicates
    that a change is a breaking change
  • I am aware that all my commits will be squashed into a single commit,
    using the PR title as the commit message.
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have updated the user-facing documentation to describe any new or
    changed behavior
  • I have added type annotations for all function/class/method interfaces
    or updated existing ones
  • I have provided JSDoc block tags for all
    functions/classes/methods or updated existing ones
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have asked the @all-contributors bot to
    acknowledge my contributions by commenting on this PR with a request of
    the form @all-contributors please add @YOUR_GH_HANDLE for TYPE_1, TYPE_2, ..., where TYPE_1 etc. refer to contribution types supported
    by the All Contributors Specification
    OR I do
    not want my contributions to be acknowledged

Comments

If there are unchecked boxes in the list above, but you would still like your
PR to be reviewed or considered for merging, please describe here why boxes
were not checked. For example, if you are positive that your commits should
not be squased when merging, please explain why you think the PR warrants
or requires multiple commits to be added to the history.

@uniqueg uniqueg merged commit bb43af6 into main Jul 13, 2022
@uniqueg uniqueg deleted the remove_template_strings branch July 13, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant