Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Helm chart version & change pathType #204

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

trispera
Copy link
Member

@trispera trispera commented Aug 16, 2024

Summary by Sourcery

Update the Helm chart version to 0.1.1 and modify the ingress pathType from 'Exact' to 'Prefix' for improved path matching flexibility.

Enhancements:

  • Change the pathType in the ingress rules from 'Exact' to 'Prefix' to allow for more flexible path matching.

Copy link

sourcery-ai bot commented Aug 16, 2024

Reviewer's Guide by Sourcery

This pull request makes two minor changes to the TESK-EXILIR Helm chart: it updates the chart version and modifies the ingress path type. The changes are implemented by editing two YAML files within the chart directory.

File-Level Changes

Files Changes
charts/tesk/Chart.yaml Incremented the chart version from 0.1.0 to 0.1.1
charts/tesk/templates/ingress/ingress-rules.yaml Changed the ingress pathType from 'Exact' to 'Prefix'

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trispera - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide some context for changing the pathType from 'Exact' to 'Prefix'? Understanding the motivation behind this change would be helpful for reviewers and future maintainers.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Contributor

@lvarin lvarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uniqueg uniqueg changed the title edit pathType build: update Helm chart version & change pathType Aug 19, 2024
@trispera trispera merged commit 966199d into master Aug 22, 2024
1 of 2 checks passed
@trispera trispera deleted the from-exact-to-prefix branch August 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants