Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add TES data models #196

Merged
merged 13 commits into from
Jul 10, 2024
Merged

chore: add TES data models #196

merged 13 commits into from
Jul 10, 2024

Conversation

JaeAeich
Copy link

@JaeAeich JaeAeich commented Jun 30, 2024

Add TES models.

Summary by Sourcery

This pull request adds comprehensive TES data models to support the TES API, enabling task creation, execution, logging, and resource management functionalities.

  • New Features:
    • Introduced TES data models for the TES API, including models for task creation, execution, logging, and resource management.

Copy link

sourcery-ai bot commented Jun 30, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new file models.py under tesk/api/ga4gh/tes/ which contains comprehensive data models for the TES API. These models are implemented using Pydantic and include detailed field definitions and descriptions. The models cover various aspects of the TES API such as task creation, execution, logging, resources, and service information.

File-Level Changes

Files Changes
tesk/api/ga4gh/tes/models.py Added comprehensive data models for TES API using Pydantic, including task definitions, logging, resources, and service information.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tesk/api/ga4gh/tes/models.py Outdated Show resolved Hide resolved
tesk/api/ga4gh/tes/models.py Outdated Show resolved Hide resolved
tesk/api/ga4gh/tes/models.py Outdated Show resolved Hide resolved
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with all of the Sourcery comments. Otherwise I think it's good.

tesk/api/ga4gh/tes/models.py Outdated Show resolved Hide resolved
tesk/api/ga4gh/tes/models.py Outdated Show resolved Hide resolved
This was referenced Jul 2, 2024
@JaeAeich JaeAeich requested a review from uniqueg July 3, 2024 04:05
uniqueg
uniqueg previously approved these changes Jul 3, 2024
@uniqueg uniqueg changed the title chore: add TES data models chore: add TES data models Jul 3, 2024
Base automatically changed from fix/remove_format_warning to main July 3, 2024 09:28
@JaeAeich JaeAeich dismissed uniqueg’s stale review July 3, 2024 09:28

The base branch was changed.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (9a61083) to head (4bb1dba).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files           8        8           
  Lines         561      561           
=======================================
  Hits          551      551           
  Misses         10       10           
Flag Coverage Δ
test_unit 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaeAeich JaeAeich requested a review from uniqueg July 3, 2024 19:12
@JaeAeich
Copy link
Author

JaeAeich commented Jul 3, 2024

Changes:

  • Ignored a bandit error, false positive.
  • Change CI install because there is no such thing as pydantic types, and I need to install pydantic to make it pass mypy checks, so install main deps for mypy check as well with types.

@uniqueg please review/approve again.

@JaeAeich JaeAeich merged commit e790298 into main Jul 10, 2024
13 checks passed
@JaeAeich JaeAeich deleted the models branch July 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants