Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image: use dissect from nix #2558

Merged
merged 1 commit into from
Nov 6, 2023
Merged

image: use dissect from nix #2558

merged 1 commit into from
Nov 6, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Nov 6, 2023 •
edited by azure-boards bot
Loading

Context

Since systemd 254, the efi partition is expected to be mounted under /boot (if both mount points /boot and /efi exist in the image).
After accounting for this new behavior, we can use systemd-dissect from nixpkgs.

Proposed change(s)

  • image: use dissect from nix

Additional info

  • AB#1234
  • Any additional information or context

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@malt3 malt3 added the no changelog Change won't be listed in release changelog label Nov 6, 2023
@malt3 malt3 added this to the v2.13.0 milestone Nov 6, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 511a232
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65490e5864441c0008be59ec

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Coverage report

Package Old New Trend
image/measured-boot/cmd [no test files] [no test files] 🚧

@malt3 malt3 merged commit 4fe51cd into main Nov 6, 2023
7 checks passed
@malt3 malt3 deleted the fix/image/dissect-from-nix branch November 6, 2023 16:50
msanft pushed a commit that referenced this pull request Nov 8, 2023
@malt3 @msanft
image: use dissect from nix (#2558)
dd18481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees

@katexochen katexochen

Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@malt3 @katexochen