Skip to content

Commit

Permalink
ci: fix relative paths for verify e2e test (#3249)
Browse files Browse the repository at this point in the history
* Use absolute paths to avoid issues with bazel run changing working directory
* Fix error message in attestationconfig cli

---------

Signed-off-by: Daniel Weiße <[email protected]>
  • Loading branch information
daniel-weisse authored Jul 12, 2024
1 parent 65ed286 commit e08ed38
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .github/actions/e2e_verify/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ runs:
run: |
reports=attestation-report-*.json
report=$(bazel run //internal/api/attestationconfigapi/cli -- compare ${{ inputs.attestationVariant }} ${reports})
# bazel run changes the working directory
# convert the relative paths to absolute paths to avoid issues
absolute_reports=""
for report in ${reports}; do
absolute_reports="${absolute_reports} $(realpath "${report}")"
done
report=$(bazel run //internal/api/attestationconfigapi/cli -- compare ${{ inputs.attestationVariant }} ${absolute_reports})
path=$(realpath "${report}")
cat "${path}"
Expand Down
4 changes: 2 additions & 2 deletions internal/api/attestationconfigapi/cli/compare.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ func compareVersions(attestationVariant variant.Variant, files []string, fs file
lowestVersion := files[0]
lowestReport, err := readReport(files[0], fs)
if err != nil {
return "", fmt.Errorf("reading tdx report: %w", err)
return "", fmt.Errorf("reading report: %w", err)
}

for _, file := range files[1:] {
report, err := readReport(file, fs)
if err != nil {
return "", fmt.Errorf("reading tdx report: %w", err)
return "", fmt.Errorf("reading report: %w", err)
}

if client.IsInputNewerThanOtherVersion(attestationVariant, lowestReport, report) {
Expand Down

0 comments on commit e08ed38

Please sign in to comment.