Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bdrs): add custom bpndidresolver token address #474

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(bdrs): add custom bpndidresolver token address #474

wants to merge 2 commits into from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Nov 5, 2024

Description

Add environment variables for bdrs token configuration.

Why

Client id and secret are more secure than API keys.

Issue

Ref: #456

Corresponding Backend PR

eclipse-tractusx/portal-backend#1129

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@tfjanjua tfjanjua requested review from evegufy and Phil91 November 5, 2024 12:53
@tfjanjua tfjanjua self-assigned this Nov 5, 2024
@tfjanjua tfjanjua added the enhancement New feature or request label Nov 5, 2024
@tfjanjua tfjanjua mentioned this pull request Nov 5, 2024
Open
6 tasks
evegufy
evegufy requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that the PR doesn't get merged until there's an according change on BDRS side eclipse-tractusx/sig-release#959 (comment)

charts/localdev/values.yaml Outdated Show resolved Hide resolved
charts/portal/templates/cronjob-backend-processes.yaml Outdated Show resolved Hide resolved
@evegufy evegufy added this to the Release 25.03 milestone Dec 13, 2024
@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Dec 13, 2024
@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

don't merge until change from BDRS side is clarified.
I was then also under the impression that you prediscussed the change with the BDRS committers, as commented here, but that doesn't seem the case, see eclipse-tractusx/bpn-did-resolution-service#120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy requested changes

@Phil91 Phil91 Awaiting requested review from Phil91

Assignees

@tfjanjua tfjanjua

Labels
enhancement New feature or request merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Portal
Status: IN REVIEW
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
2 participants
@tfjanjua @evegufy