Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: upgrade knowledge agent references according to TX/CX 2412 versions. #1111

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feature: upgrade knowledge agent references according to TX/CX 2412 versions. #1111

wants to merge 7 commits into from
+395 −379

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Dec 9, 2024

Description

updates KA KIT according to 2412 versions.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@drcgjung drcgjung added the documentation Improvements or additions to documentation label Dec 9, 2024
obalandi
obalandi approved these changes Dec 9, 2024
View reviewed changes
Copy link

@obalandi obalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jSchuetz88
jSchuetz88 suggested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jSchuetz88 jSchuetz88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update / removal of the Catena-X NG references.
Unfortunately, most of the links don't seem to work as they result into 404 pages. Are these repositories private?

Additionally, as the new release has already been created and published, this changes need to be included into /docs-kits_versioned_docs/... too.

docs-kits/kits/knowledge-agents/development-view/api.md Outdated Show resolved Hide resolved
@drcgjung drcgjung requested a review from jSchuetz88 December 10, 2024 07:11
@drcgjung drcgjung requested a review from jSchuetz88 December 12, 2024 06:54
@stephanbcbauer
Copy link
Member

@jSchuetz88 since these changes are related to 24.12 and this was already released ... do we have an issue? The current PR adapts everything in docs-kits, but shouldn't it also adapt 24.12 in kits?

@drcgjung
Copy link
Contributor Author

@jSchuetz88 since these changes are related to 24.12 and this was already released ... do we have an issue? The current PR adapts everything in docs-kits, but shouldn't it also adapt 24.12 in kits?

@stephanbcbauer please see included commit 6342502 which clones all changes to the versioned folder as well.

@stephanbcbauer
Copy link
Member

@jSchuetz88 fine for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obalandi obalandi obalandi approved these changes

@stephanbcbauer stephanbcbauer Awaiting requested review from stephanbcbauer

@jSchuetz88 jSchuetz88 Awaiting requested review from jSchuetz88

At least 1 approving review is required to merge this pull request.

Assignees

@stephanbcbauer stephanbcbauer

@jSchuetz88 jSchuetz88

Labels
documentation Improvements or additions to documentation
Projects
Knowledge Agent Kanban Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drcgjung @stephanbcbauer @obalandi @jSchuetz88