Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gear_ratio parameter #95

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

Tacha-S
Copy link

@Tacha-S Tacha-S commented Dec 10, 2024

I added the gear_ratio parameter to enable combining gears.
Since the default value is set to 1.0, there will be no changes to the existing behavior.

@Tacha-S
Copy link
Author

Tacha-S commented Jan 8, 2025

@ijnek @youtalk or other maintainer, could you review it (and #96 , #98 )?
Or is this repository already out of maintenance and no longer maintained by anyone?

Copy link
Member

@ijnek ijnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @Tacha-S. I try to keep this repo maintained, but I appreciate the @mention, because it can get lost sometimes.
Could I ask, is it necessary to handle this in the hardware interface? What is the advantage of putting the gear ratio in the hardware interface, compared to using a URDF transmission tag?

@Tacha-S
Copy link
Author

Tacha-S commented Jan 15, 2025

@ijnek Thank you for the review.
It is true that mechanicalReduction is defined in the transmission tag of URDF.
However, as far as I know, there has not been a way to send commands while considering these definitions, which is why I had prepared parameters separately.
Upon investigation, I found that in ROS 2, there is an approach to reflect transmission into the hardware interface, as demonstrated in the following example:
https://github.com/ros-controls/ros2_control_demos/tree/master/example_8
While this is not directly implementing the transmission definition itself, it seems to introduce it in a way that aligns with the intent of the definition to some extent.

What do you think about making the dynamixel_hardware capable of handling mechanicalReduction, similar to the method in this example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling gear ratio functionality
2 participants