Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chemicalpleasures I've done first round of code review on this and a lot of the things I noticed are actually picked up with
eslint
debugger in places where you have empty variables and missing syntax. In total there are about 100+ errors picked up by debugger which I would resolve all of them to make your code A++ and also not cause any deployment issues.To run eslint
Switch to this branch, do a fresh
npm install
to geteslint
installed properly. Now from the terminal you can run the commandnpx eslint pages
pages being the folder name you are scanning. Do this to each folder with .js / .jsx / .tsx files to scan all of your ones. Each time you fix a problem, run the eslinter again to scan to see if you're resolves. Once you no longer get any errors coming from eslint you know you're in the clear!Here is the output from the
pages
folder which gives you an idea on the errors there are to resolve.