fix: #362 Register PreviewHandler on Win10 190042ff #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alas described differently in MSDN https://docs.microsoft.com/en-us/windows/win32/shell/how-to-register-a-preview-handler a PreviewHandler (additionally or only) needs ShellEx\{8895b1c6-b41f-4c1c-a562-0d564250836f} below the association key. The MSDN sample https://github.com/microsoft/Windows-classic-samples/blob/27ffb0811ca761741502feaefdb591aebf592193/Samples/Win7Samples/winui/shell/appshellintegration/RecipePreviewHandler/dll.cpp#L206 creates the ShellEx key only below the association key, not the class name key.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 11.79% 11.76% -0.04%
==========================================
Files 89 89
Lines 3060 3068 +8
Branches 388 392 +4
==========================================
Hits 361 361
- Misses 2680 2687 +7
- Partials 19 20 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas described differently in MSDN https://docs.microsoft.com/en-us/windows/win32/shell/how-to-register-a-preview-handler
a PreviewHandler (additionally or only) needs ShellEx{8895b1c6-b41f-4c1c-a562-0d564250836f} below the association key.
The MSDN sample https://github.com/microsoft/Windows-classic-samples/blob/27ffb0811ca761741502feaefdb591aebf592193/Samples/Win7Samples/winui/shell/appshellintegration/RecipePreviewHandler/dll.cpp#L206 creates the ShellEx key only below the association key, not the class name key.
See #362
cc @AdmiralSnyder