-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dunification of Zarith #2
base: duniverse-new-master
Are you sure you want to change the base?
Conversation
Generally looks good. Would it be possible to wrap the upstream ./configure invocation in the dune file, rather than the manual shell invocations? Ideally the ./configure script should be the canonical way by which the dune cross-compilation is configured. |
I can try to do that but the configure script is not cross-compilation ready, it's looking for a global |
@avsm Updated the PR: I wrapped the configure script, using env variables to control |
This PR is a new proposal for the dunification of Zarith, based on the latest changes on Zarith's upstream.
Thanks to ocaml#94, the
dune
switch becomes much simpler.This port has two goals:
gmp
library https://github.com/mirage/ocaml-gmp, so that when it's vendored, gmp is cross-compiled using workspace flags and cc.conf-gmp
opam package). This allows to use zarith for building host binaries without having to rebuild gmp.(1) is implemented with the three first commits. (2) is achieved through the last commit, which adds some complexity to choose between
conf-gmp
(system gmp) andgmp
(self built gmp).I also added end-to-end tests, both for the host system and a cross-compiled setup (with solo5/ocaml-freestanding).
This is not to merge right now, it depends on: