Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #3051 main_v12.0 unit test decouple install dir from repo #3052

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

georgemccabe
Copy link
Collaborator

These changes allow the unit tests to be run to test a MET installation that is found in another location besides the MET repository source code.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Ran tests on seneca to test a conda installation of MET. I made sure that the files that are in the repository and not installed are found relative to the test_unit directory and files that should be installed are referenced relative to MET_BASE.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all automated tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Removed references to MET_BUILD_BASE since we no longer require it to be set to run the tests

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 1/17/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ve to MET_BASE (<install_loc>/share/met) and other files that are only in the MET repo are found relative to MET_TEST_BASE (MET/internal/test_unit). Also remove MET_BUILD_BASE env var
@georgemccabe georgemccabe added this to the MET-12.0.1 (bugfix) milestone Jan 16, 2025
@georgemccabe georgemccabe linked an issue Jan 16, 2025 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. The changes match what we already discussed, and I'm glad to see all the GHA tests passed. Thanks for wrapping this up.

@georgemccabe georgemccabe merged commit 958d47c into main_v12.0 Jan 17, 2025
66 checks passed
@georgemccabe georgemccabe deleted the bugfix_3051_main_v12.0_test_install branch January 17, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Decouple MET unit tests from MET install location
2 participants