fix: the registry host namespace should include the port #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaius-qi
requested changes
Jan 18, 2024
There was a problem hiding this comment.
@yetone Please add changelog and update chart version, refer to https://github.com/dragonflyoss/helm-charts/pull/190/files.
Helm charts use helm-docs to generate helm documents, refer to https://github.com/dragonflyoss/helm-charts/tree/main/charts.
yetone
force-pushed
the
fix/registry-host-namespace-contains-port
branch
2 times, most recently
from
65d9ce0 to
11e8524
Compare
yetone
force-pushed
the
fix/registry-host-namespace-contains-port
branch
from
11e8524 to
b137bf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the container documentation, the registry host namespace should include a port. I have also tested this in practice; the
hosts.tomlconfiguration under thecerts.d/127.0.0.1directory indeed does not affectcrictl pull 127.0.0.1:5000/xxx. Therefore, you should create acerts.d/127.0.0.1:5000directory.https://github.com/containerd/containerd/blob/main/docs/hosts.md#registry-host-namespace
Related Issue
Motivation and Context
Solve the issue of invalid mirror for registry with port.