feat: auto detect storage volumeMount while setting it in volumeMounts #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weixiao-huang
force-pushed
the
feat/auto-check-storage-mount
branch
from
8b0d963 to
3000d7f
Compare
|
@weixiao-huang Please fix lint. |
weixiao-huang
force-pushed
the
feat/auto-check-storage-mount
branch
4 times, most recently
from
5da41b1 to
29c7008
Compare
|
I've successfully fixed lint, is there any progress? |
Signed-off-by: weixiao-huang <[email protected]>
Signed-off-by: weixiao-huang <[email protected]>
weixiao-huang
force-pushed
the
feat/auto-check-storage-mount
branch
from
29c7008 to
87310a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we could only use PVC or emptyDir storage for seek-peer in this helm chart. I add a detection in extraVolumeMounts if user sets storage in volumeMounts when there's no persistent storage
Related Issue
Motivation and Context