Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pieceLength for creating persistent cache task #3772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes several updates to dependency versions and various enhancements and fixes in the scheduler service. The most important changes include updating dependencies in the go.mod file, adding a new field to the NewTask function, replacing status.Errorf with status.Error for error handling, and adding logging statements to various functions in the scheduler service.

Dependency updates:

  • Updated d7y.io/api/v2 to version v2.1.10 and google.golang.org/grpc to version v1.69.4 in go.mod. [1] [2]

Enhancements and fixes in scheduler service:

  • Added PieceLength field to the NewTask function in scheduler/resource/persistentcache/task.go.
  • Replaced status.Errorf with status.Error for error handling in multiple functions in scheduler/service/service_v2.go. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Added logging statements to various functions in scheduler/service/service_v2.go to improve traceability and debugging. [1] [2] [3] [4] [5] [6]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 20, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 20, 2025
@gaius-qi gaius-qi self-assigned this Jan 20, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 20, 2025 04:13
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.

Project coverage is 34.58%. Comparing base (a63126e) to head (e163f9f).

Files with missing lines Patch % Lines
scheduler/service/service_v2.go 8.10% 34 Missing ⚠️
scheduler/resource/persistentcache/task.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3772      +/-   ##
==========================================
- Coverage   34.67%   34.58%   -0.10%     
==========================================
  Files         337      337              
  Lines       38533    38548      +15     
==========================================
- Hits        13363    13332      -31     
- Misses      24335    24375      +40     
- Partials      835      841       +6     
Flag Coverage Δ
unittests 34.58% <7.89%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/task.go 0.00% <0.00%> (ø)
scheduler/service/service_v2.go 50.55% <8.10%> (-0.35%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants