-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement FindCandidatePersistentCacheParents for scheduling persistent cache task #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaius-qi
force-pushed
the
feature/find
branch
3 times, most recently
from
January 16, 2025 14:44
2be3860
to
1d65e7a
Compare
CormickKneey
previously approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaius-qi
force-pushed
the
feature/find
branch
from
January 17, 2025 02:59
1d65e7a
to
ab3dbed
Compare
…rsistent cache task Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/find
branch
from
January 17, 2025 03:08
ab3dbed
to
1856341
Compare
chlins
reviewed
Jan 17, 2025
gaius-qi
force-pushed
the
feature/find
branch
4 times, most recently
from
January 17, 2025 10:35
750faee
to
97d703f
Compare
…/find Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/find
branch
from
January 17, 2025 10:43
97d703f
to
0bd3ccb
Compare
hhhhsdxxxx
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes significant changes to the
scheduler
component, primarily focusing on adding new metrics, modifying theHost
struct, updating peer states, and enhancing the evaluator logic. Below are the most important changes grouped by theme:Metrics Addition:
scheduler/metrics/metrics.go
. These include counts for register, download, and failure events for persistent cache peers and pieces.Host Struct and Related Functions:
ConcurrentUploadLimit
,ConcurrentUploadCount
,UploadCount
, andUploadFailedCount
fields from theHost
struct inscheduler/resource/persistentcache/host.go
. AddedSchedulerClusterID
field.NewHost
function to remove options for setting concurrent upload limits and counts, and addedschedulerClusterId
parameter. [1] [2]Load
andStore
functions inscheduler/resource/persistentcache/host_manager.go
to handle the newSchedulerClusterID
field and remove handling of concurrent upload limits and counts. [1] [2] [3] [4]Peer States and Events:
scheduler/resource/persistentcache/peer.go
. AddedPeerStateReceivedEmpty
,PeerStateReceivedNormal
,PeerEventRegisterEmpty
, andPeerEventRegisterNormal
. [1] [2] [3]Task Size Scope:
SizeScope
method in theTask
struct to determine the size scope type inscheduler/resource/persistentcache/task.go
. [1] [2]Evaluator Enhancements:
scheduler/scheduling/evaluator/evaluator.go
. [1] [2] [3] [4]persistentcache
package in relevant files. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist