Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the e2e file server #3741

Merged
merged 1 commit into from
Jan 9, 2025
Merged

refactor: refactor the e2e file server #3741

merged 1 commit into from
Jan 9, 2025

Conversation

chlins
Copy link
Member

@chlins chlins commented Jan 2, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@chlins chlins requested review from a team as code owners January 2, 2025 03:01
@chlins chlins requested review from yxxhero, gaius-qi and hyy0322 January 2, 2025 03:01
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.12%. Comparing base (25a4b53) to head (731cd31).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3741      +/-   ##
==========================================
- Coverage   35.14%   35.12%   -0.03%     
==========================================
  Files         336      336              
  Lines       37852    37852              
==========================================
- Hits        13303    13295       -8     
- Misses      23720    23725       +5     
- Partials      829      832       +3     
Flag Coverage Δ
unittests 35.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@chlins chlins force-pushed the refactor/e2e-test branch 16 times, most recently from 48d7254 to 2b96b37 Compare January 8, 2025 02:43
test/e2e/v2/util/dufs.go Outdated Show resolved Hide resolved
test/e2e/v2/util/dufs.go Outdated Show resolved Hide resolved
test/e2e/v2/util/file.go Outdated Show resolved Hide resolved
test/e2e/v2/util/file.go Outdated Show resolved Hide resolved
test/e2e/v2/util/file.go Show resolved Hide resolved
@chlins chlins force-pushed the refactor/e2e-test branch from 2b96b37 to 9937f6e Compare January 8, 2025 06:55
@gaius-qi gaius-qi added the enhancement New feature or request label Jan 8, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 8, 2025
@chlins chlins force-pushed the refactor/e2e-test branch from 9937f6e to 4c135a0 Compare January 8, 2025 07:43
@chlins chlins force-pushed the refactor/e2e-test branch from 4c135a0 to 731cd31 Compare January 9, 2025 04:19
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins changed the title [WIP] refactor: refactor the e2e file server refactor: refactor the e2e file server Jan 9, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d7f9e91 into main Jan 9, 2025
26 checks passed
@gaius-qi gaius-qi deleted the refactor/e2e-test branch January 9, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants