Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pex replica clean logic #3272

Merged
merged 3 commits into from
May 16, 2024
Merged

chore: update pex replica clean logic #3272

merged 3 commits into from
May 16, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented May 15, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner May 15, 2024 05:52
@jim3ma jim3ma force-pushed the chore/pex-replica-clean branch from 366ae6a to 45f2a3e Compare May 15, 2024 06:00
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 52.67%. Comparing base (7c69d5d) to head (32747cd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   52.87%   52.67%   -0.20%     
==========================================
  Files         192      192              
  Lines       20372    20399      +27     
==========================================
- Hits        10772    10746      -26     
- Misses       8798     8846      +48     
- Partials      802      807       +5     
Flag Coverage Δ
unittests 52.67% <40.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/config/peerhost.go 47.46% <ø> (ø)
client/config/peerhost_linux.go 100.00% <100.00%> (ø)
client/daemon/pex/peer_exchange.go 69.94% <21.05%> (-11.27%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 3ddf37a into main May 16, 2024
28 checks passed
@jim3ma jim3ma deleted the chore/pex-replica-clean branch May 16, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants