-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Test Information from the New Testing Platform #42494
Merged
MarcoRossignoli
merged 16 commits into
main
from
dev/mabdullah/HandleTestsInfoFromTestHost
Aug 9, 2024
Merged
Handle Test Information from the New Testing Platform #42494
MarcoRossignoli
merged 16 commits into
main
from
dev/mabdullah/HandleTestsInfoFromTestHost
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receive session started/ended Store output and error data from the new testing platform
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
Request triage from a team member
labels
Aug 1, 2024
mariam-abdulla
changed the title
Handle Test Results from the New Testing Platform
Handle Test Information from the New Testing Platform
Aug 1, 2024
Evangelink
reviewed
Aug 2, 2024
Evangelink
reviewed
Aug 2, 2024
…ithub.com/dotnet/sdk into dev/mabdullah/HandleTestsInfoFromTestHost
src/Cli/dotnet/commands/dotnet-test/IPC/Models/FileArtifactInfo.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-test/IPC/Serializers/BaseSerializer.cs
Outdated
Show resolved
Hide resolved
MarcoRossignoli
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good some nits
…ithub.com/dotnet/sdk into dev/mabdullah/HandleTestsInfoFromTestHost
MarcoRossignoli
approved these changes
Aug 9, 2024
Relates to #45927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We receive the below:
and we send handshake info back.
We also store the output/error data of the testing platform.