Simplify PublicTopLevelProgramGenerator

[Youssef1313]

Simplify PublicTopLevelProgramGenerator

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Simplifies the generator

Description

There is no need to have multiple transformations in the generator.

Fixes #{bug number} (in this specific format)

[captainsafia]

Thanks for opening this PR, @Youssef1313! It looks like there's some build errors that need to be resolved.

BTW, I recognize that multiple transformations aren't necessarily needed, but is there a harm to having them? Also in this case, I figured there might be some value to having some transformations (like the resolution of the syntax nodes) as the last stage in case other transformations fail.

[Youssef1313]

is there a harm to having them?

@captainsafia I think yes. It' likely better as a single step. This avoids caching symbols which will be not equatable anyways (not sure if it can cause leak or not though)

@CyrusNajmabadi will be better to advise.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[captainsafia]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[captainsafia]

I hit approve too fast. It looks like this change introduced some test regressions.

[CyrusNajmabadi]

BTW, I recognize that multiple transformations aren't necessarily needed, but is there a harm to having them?

yes. Each step is a new table in our pipeline that we have to compute and compare before/after. Symbols in these steps are particularly bad as they will always compare false. so it's just added cost (both memory and cpu) that never improves incrementality.

[Youssef1313]

@captainsafia This is hopefully good to merge if CI goes green.